Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haptic: Feature to disable haptic feedback when USB is not configured or suspended #12487

Conversation

purdeaandrei
Copy link
Contributor

  • also haptic status led pin feature.

Description

Please review, mostly for code organization issues, this is not yet tested, so not yet ready to be merged.
(Will test it an an AVR keyboard next weekend)
Note: in chibios land I used USB_DRIVER macro which points to a global variable.
In order to use a "usbp" pointer I'd have to refactor the code to also store a usbp pointer in the queue.

Types of Changes

  • Core
  • Bugfix (technically a bugfix, cause we likely aren't respecting USB specs, with haptic feedback enabled in low power states)
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
    Not yet tested, and not yet ready to merge, but please review.

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pull out the power changes, and put those into a separate PR?

@purdeaandrei
Copy link
Contributor Author

@drashna:
I have split up the changes into two different PRs, please review this:

#12691
#12692

The new set of changes has now been tested on chibios.

I am closing this PR

@drashna
Copy link
Member

drashna commented Apr 25, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants